Skip to content
Snippets Groups Projects

Compare revisions

Changes are shown as if the source revision was being merged into the target revision. Learn more about comparing revisions.

Source

Select target project
No results found
Select Git revision
  • 279-make-all-tests-pass-for-ci-pipeline
  • 33-improve-hyrax-seed-setup-json-user-creation-no-hardcoded-passwords-added-shibboleth-support
  • 40-change-customer-facing-product-name-to-reseed
  • add-comments-to-env-templates
  • bug-fix/275-emplement-clear-layout-for-crc
  • bug/220-fixes-for-unlogged-in-user
  • bug/250-fix-collection-public-view
  • bug/257-fix-front-end-validation-for-title
  • bug/259-fix-sharing-tab-add-group
  • bug/272-download_all_button_not_showing_on_draft
  • bug/fix-delete-button-for-rub
  • bug/fix-remove-button-for-location
  • bug/fix-subject-and-modality-form-issue
  • bug/fix-workflow-action-visibility
  • bug/fix-workflow-action-visibility_2
  • bug/unable-to-add-100s-of-files
  • bug_fix/247_enter_key_triggers_wrong_button
  • bug_fix/260-default-funder-information-not-saving
  • bug_fix/266_make_submit_button_work
  • bug_fix/270-list-works-in-under-review-tab
  • bug_fix/274-452-filtered-download-issue
  • bug_fix/276_search_label_for_works
  • bug_fix/308_rename_file_if_duplicate
  • bug_fix/314_change_error_message
  • bug_fix/316_alphanumeric_sort
  • bug_fix/318_js_folder_name_validation
  • bug_fix/318_sanitize_titles
  • bug_fix/330_fileset_sorting_issue
  • bug_fix/332_fix_session_name_in_verification
  • bug_fix/334-folder-name-duplication-issue
  • bug_fix/341-remove-files-folder-from-s3
  • bug_fix/341_rake_task_for_meta_json
  • bug_fix/346-safari-does-not-properly-display-the-files-tab
  • bug_fix/355_range_segments_error
  • bug_fix/356-fix-meta-json-file
  • bug_fix/356-map-meta-file-with-correct-attributes
  • bug_fix/356-maping-of-attributes-for-meta-json
  • bug_fix/369-fileset-title-issue
  • bug_fix/375-file-not-visible-in-viewer
  • bug_fix/381_create_downloads_volume
  • bug_fix/396-delete-download-folder-after-zip-file-created
  • bug_fix/430-zip-file-count-mismatch
  • bug_fix/443_improve_agreement_date_check
  • bug_fix/44_alphanumeric_sorting_for_fileset
  • bug_fix/454_gather_hidden_files
  • bug_fix/455-new-groups-not-added-as-child-in-crc1280
  • bug_fix/462_resource_type_mapping
  • bug_fix/467-filset-accessibility
  • bug_fix/487-public-view-for-collection
  • bug_fix/add_restriction_in_collecton_search
  • bug_fix/added_validation_parent_collection
  • bug_fix/allow-draft-works-to-show-in-catalog-search
  • bug_fix/disable_agreement
  • bug_fix/documentation
  • bug_fix/doi_display
  • bug_fix/download_script
  • bug_fix/edit_form_#427
  • bug_fix/endnote_url
  • bug_fix/fileset_title_uniqueness_issue
  • bug_fix/fixed_all_test_cases
  • bug_fix/fixes-for-issue-23-24
  • bug_fix/fixes-for-issues-14-15-21-23-24-26
  • bug_fix/fixes-for-issues-36-32
  • bug_fix/fixes_sanitize_complex_titles
  • bug_fix/hide-associated-data-on-tombstone
  • bug_fix/i220_deposit_permission
  • bug_fix/importer-issue-and-issues-19-12
  • bug_fix/importer_issues_25_33_34
  • bug_fix/issue_20_35
  • bug_fix/make_s3_folder_name_immutable
  • bug_fix/make_testsuite_pass
  • bug_fix/optimize_sorting_for_children_of_crc_dataset
  • bug_fix/pagination_issue_on_experiment_page
  • bug_fix/range_facet_for_age
  • bug_fix/remove_file_size_computation
  • bug_fix/rename_subject_title
  • bug_fix/search_label
  • bug_fix/session_date_picker_visibility
  • bug_fix/single_use_download_link
  • bug_fix/undefined-method-proxy-depositor
  • bug_fix/uploaded_file_message
  • bug_fix/uv_local_js
  • change/275-redesign-crc-dataset-show-page
  • changes/140-customise-modality-form
  • changes/249-reorder-workflow-comments
  • changes/255-update-deposit-label-for-workflow
  • changes/269_meta_data_for_experiments
  • changes/294_modify_breadcrumb_for_crc_1280_datasets
  • changes/revoke-sanitizaton-of-title
  • cl-test
  • clarify_options_for_selecting_work_type
  • customized_error_pages
  • develop
  • develop-duplicate
  • develop-pascal
  • display_depositor_on_work_show_page
  • enhancement/user-experience-with-form
  • feature-fix-docker-entrypoint-fcrepo
  • feature/102_remove_paginations
  • feature/113-implement-error-page-for-s3-connection-fail
  • v0.2
  • v0.2.1
  • v0.3
  • v0.3.1
  • v0.3.2
  • v0.3.3
  • v0.3.4
  • v0.3.5
  • v0.3.6
  • v0.3.7
  • v0.3.8
  • v1.0-beta-5
  • v1.0-beta-6
  • v1.0-beta-7
  • v1.0-beta1
  • v1.0-beta2
  • v1.0-beta3
  • v1.0-beta3-10-g353506d_2024-04-23T09-43-10UTC
  • v1.0-beta3-3-ge6f08da_2024-04-16T11-30-54UTC
  • v1.0-beta3-32-g4457433_2024-05-16T06-39-18UTC
  • v1.0-beta3-33-g38db6d3_2024-05-22T15-51-39UTC
  • v1.0-beta3-9-ge461daa_2024-04-22T14-15-33UTC
  • v1.0-beta4
  • v1.0-beta4-14-gd64f165_2024-07-10T12-53-06UTC
  • v1.0-beta5
125 results

Target

Select target project
  • researchdata/rdms
1 result
Select Git revision
  • 279-make-all-tests-pass-for-ci-pipeline
  • 33-improve-hyrax-seed-setup-json-user-creation-no-hardcoded-passwords-added-shibboleth-support
  • 40-change-customer-facing-product-name-to-reseed
  • add-comments-to-env-templates
  • bug-fix/275-emplement-clear-layout-for-crc
  • bug/220-fixes-for-unlogged-in-user
  • bug/250-fix-collection-public-view
  • bug/257-fix-front-end-validation-for-title
  • bug/259-fix-sharing-tab-add-group
  • bug/272-download_all_button_not_showing_on_draft
  • bug/fix-delete-button-for-rub
  • bug/fix-remove-button-for-location
  • bug/fix-subject-and-modality-form-issue
  • bug/fix-workflow-action-visibility
  • bug/fix-workflow-action-visibility_2
  • bug/unable-to-add-100s-of-files
  • bug_fix/247_enter_key_triggers_wrong_button
  • bug_fix/260-default-funder-information-not-saving
  • bug_fix/266_make_submit_button_work
  • bug_fix/270-list-works-in-under-review-tab
  • bug_fix/274-452-filtered-download-issue
  • bug_fix/276_search_label_for_works
  • bug_fix/308_rename_file_if_duplicate
  • bug_fix/314_change_error_message
  • bug_fix/316_alphanumeric_sort
  • bug_fix/318_js_folder_name_validation
  • bug_fix/318_sanitize_titles
  • bug_fix/330_fileset_sorting_issue
  • bug_fix/332_fix_session_name_in_verification
  • bug_fix/334-folder-name-duplication-issue
  • bug_fix/341-remove-files-folder-from-s3
  • bug_fix/341_rake_task_for_meta_json
  • bug_fix/346-safari-does-not-properly-display-the-files-tab
  • bug_fix/355_range_segments_error
  • bug_fix/356-fix-meta-json-file
  • bug_fix/356-map-meta-file-with-correct-attributes
  • bug_fix/356-maping-of-attributes-for-meta-json
  • bug_fix/369-fileset-title-issue
  • bug_fix/375-file-not-visible-in-viewer
  • bug_fix/381_create_downloads_volume
  • bug_fix/396-delete-download-folder-after-zip-file-created
  • bug_fix/430-zip-file-count-mismatch
  • bug_fix/443_improve_agreement_date_check
  • bug_fix/44_alphanumeric_sorting_for_fileset
  • bug_fix/454_gather_hidden_files
  • bug_fix/455-new-groups-not-added-as-child-in-crc1280
  • bug_fix/462_resource_type_mapping
  • bug_fix/467-filset-accessibility
  • bug_fix/487-public-view-for-collection
  • bug_fix/add_restriction_in_collecton_search
  • bug_fix/added_validation_parent_collection
  • bug_fix/allow-draft-works-to-show-in-catalog-search
  • bug_fix/disable_agreement
  • bug_fix/documentation
  • bug_fix/doi_display
  • bug_fix/download_script
  • bug_fix/edit_form_#427
  • bug_fix/endnote_url
  • bug_fix/fileset_title_uniqueness_issue
  • bug_fix/fixed_all_test_cases
  • bug_fix/fixes-for-issue-23-24
  • bug_fix/fixes-for-issues-14-15-21-23-24-26
  • bug_fix/fixes-for-issues-36-32
  • bug_fix/fixes_sanitize_complex_titles
  • bug_fix/hide-associated-data-on-tombstone
  • bug_fix/i220_deposit_permission
  • bug_fix/importer-issue-and-issues-19-12
  • bug_fix/importer_issues_25_33_34
  • bug_fix/issue_20_35
  • bug_fix/make_s3_folder_name_immutable
  • bug_fix/make_testsuite_pass
  • bug_fix/optimize_sorting_for_children_of_crc_dataset
  • bug_fix/pagination_issue_on_experiment_page
  • bug_fix/range_facet_for_age
  • bug_fix/remove_file_size_computation
  • bug_fix/rename_subject_title
  • bug_fix/search_label
  • bug_fix/session_date_picker_visibility
  • bug_fix/single_use_download_link
  • bug_fix/undefined-method-proxy-depositor
  • bug_fix/uploaded_file_message
  • bug_fix/uv_local_js
  • change/275-redesign-crc-dataset-show-page
  • changes/140-customise-modality-form
  • changes/249-reorder-workflow-comments
  • changes/255-update-deposit-label-for-workflow
  • changes/269_meta_data_for_experiments
  • changes/294_modify_breadcrumb_for_crc_1280_datasets
  • changes/revoke-sanitizaton-of-title
  • cl-test
  • clarify_options_for_selecting_work_type
  • customized_error_pages
  • develop
  • develop-duplicate
  • develop-pascal
  • display_depositor_on_work_show_page
  • enhancement/user-experience-with-form
  • feature-fix-docker-entrypoint-fcrepo
  • feature/102_remove_paginations
  • feature/113-implement-error-page-for-s3-connection-fail
  • v0.2
  • v0.2.1
  • v0.3
  • v0.3.1
  • v0.3.2
  • v0.3.3
  • v0.3.4
  • v0.3.5
  • v0.3.6
  • v0.3.7
  • v0.3.8
  • v1.0-beta-5
  • v1.0-beta-6
  • v1.0-beta-7
  • v1.0-beta1
  • v1.0-beta2
  • v1.0-beta3
  • v1.0-beta3-10-g353506d_2024-04-23T09-43-10UTC
  • v1.0-beta3-3-ge6f08da_2024-04-16T11-30-54UTC
  • v1.0-beta3-32-g4457433_2024-05-16T06-39-18UTC
  • v1.0-beta3-33-g38db6d3_2024-05-22T15-51-39UTC
  • v1.0-beta3-9-ge461daa_2024-04-22T14-15-33UTC
  • v1.0-beta4
  • v1.0-beta4-14-gd64f165_2024-07-10T12-53-06UTC
  • v1.0-beta5
125 results
Show changes
Commits on Source (4)
  • Pascal Ernster's avatar
    Generate random passwords with SecureRandom instead of Devise.friendly_token · 5fb7184a
    Pascal Ernster authored
    It seems that `User` objects can't be created with a `nil` password, so we have to set a password even for Shibboleth and ORCID user accounts, even though that password is never supposed to be used. Currently, we use `Devise.friendly_token` for this, but `SecureRandom` seems a better choice since it doesn't incur external dependencies/3rd party libraries (even though we currently use `Devise` nonetheless).
    
    Note: This does create passwords with binary/non-printable characters.
    Given the 32 byte length chosen, this gives us 256 bit entropy per
    password.
    Verified
    5fb7184a
  • Pascal Ernster's avatar
    Remove hyrax/seed/crc_users.json · f16e7f54
    Pascal Ernster authored
    According to @anusha, `hyrax/seed/crc_users.json` isn't needed anymore,
    so let's remove it.
    Verified
    f16e7f54
  • Anusha Ranganathan's avatar
    Merge branch '35-remove-hyrax-seed-crc_users-json' into 'develop' · c5ff9847
    Anusha Ranganathan authored
    Remove hyrax/seed/crc_users.json
    
    See merge request FDM/rdm-system/rdms!126
    c5ff9847
  • Anusha Ranganathan's avatar
    Merge branch... · 237a70bd
    Anusha Ranganathan authored
    Merge branch '32-generate-random-passwords-with-securerandom-instead-of-devise-friendly_token' into 'develop'
    
    Generate random passwords with SecureRandom instead of Devise.friendly_token
    
    See merge request FDM/rdm-system/rdms!123
    237a70bd
......@@ -78,7 +78,7 @@ class User < ApplicationRecord
if ENV.fetch('ORCID_RESTRICT_AUTHORIZATION', 'true') == 'false'
user.display_name = auth.info.name
user.email = auth.info.email || "#{auth.uid}@#{auth.provider.to_s}"
user.password = Devise.friendly_token[0,20]
user.password = SecureRandom.random_bytes(32)
end
user.save!
user
......@@ -108,7 +108,7 @@ class User < ApplicationRecord
user.uid = attributes[:uid]
user.display_name = attributes[:name]
user.email = attributes[:email]
user.password = Devise.friendly_token[0,20]
user.password = SecureRandom.random_bytes(32)
user.save!
user
......
{
"users": [
{
"email": "user@hyrax",
"password": "password",
"name": "Demo user",
"affiliation": "",
"orcid": "",
"role": ["CRC manager"]
},
{
"email": "user2@hyrax",
"password": "password",
"name": "Demo user 2",
"affiliation": "",
"orcid": "",
"role": ["CRC member"]
},
{
"email": "user3@hyrax",
"password": "password",
"name": "Demo user 3",
"affiliation": "",
"orcid": "",
"role": ["CRC member","A01 manager"]
},
{
"email": "user4@hyrax",
"password": "password",
"name": "Demo user 4",
"affiliation": "",
"orcid": "",
"role": ["CRC member","A01 member"]
}
]
}