Cleaned up expiry conversion to seconds

hyrax/app/services/s3_storage_service.rb

@@ -228,13 +228,14 @@ class S3StorageService
     end
   end
 
-  def presigned_url_for_download(bucket_name, file_key, expiry = ENV.fetch('S3_EXPIRY', 1).to_i.days)
+  def presigned_url_for_download(bucket_name, file_key, expiry = ENV.fetch('S3_EXPIRY', 1))
     bucket = Aws::S3::Resource.new(region: ENV['S3_REGION']).bucket(bucket_name)
     url_options = {
       response_content_disposition: "attachment; filename=\"#{file_key}\""
     }
 
-    url_options[:expires_in] = expiry.to_i if expiry.present?
+    # S3_EXPIRY is in days. expiry.days.to_i converts it to seconds
+    url_options[:expires_in] = expiry.to_i.days.to_i if expiry.present?
 
     object = bucket.object(file_key)
     object.exists? ? object.presigned_url(:get, url_options).to_s : nil